!52 xfs_db: use preferable macro to seek offset for local dir3 entry fields

From: @hexiaole1994 
Reviewed-by: @liuzhiqiang26 
Signed-off-by: @liuzhiqiang26

0014-xfs_db-use-preferable-macro-to-seek-offset-for-local.patch

@@ -0,0 +1,63 @@
+From a879b7f6aecba2cbda925e21e95e7d4752eed0b8 Mon Sep 17 00:00:00 2001
+From: Xiaole He <hexiaole1994@126.com>
+Date: Mon, 29 Aug 2022 17:50:25 +0800
+Subject: [PATCH] xfs_db: use preferable macro to seek offset for local dir3
+ entry fields
+
+In 'xfsprogs-dev' source:
+
+/* db/dir2sf.c begin */
+ #define        EOFF(f) bitize(offsetof(xfs_dir2_sf_entry_t, f))
+const field_t   dir2_sf_entry_flds[] = {
+        { "namelen", FLDT_UINT8D, OI(EOFF(namelen)), C1, 0, TYP_NONE },
+...
+ #define        E3OFF(f)        bitize(offsetof(xfs_dir2_sf_entry_t, f))
+const field_t   dir3_sf_entry_flds[] = {
+        { "namelen", FLDT_UINT8D, OI(EOFF(namelen)), C1, 0, TYP_NONE },
+...
+/* db/dir2sf.c end */
+
+The macro definitions of 'EOFF' and 'E3OFF' are same, so no matter to
+use either to seek field offset in 'dir3_sf_entry_flds'.
+But it seems the intent of defining 'E3OFF' macro is to be used in
+'dir3_sf_entry_flds', and 'E3OFF' macro has not been used at any place
+of the 'xfsprogs-dev' source:
+
+/* command begin */
+$ grep -r E3OFF /path/to/xfsprogs-dev/git/repository/
+./db/dir2sf.c:#define   E3OFF(f)        bitize(offsetof(xfs_dir2_sf_entry_t, f))
+$
+/* command end */
+
+Above command shows the 'E3OFF' is only been defined but nerver been
+used, that is weird, so there has reason to suspect using 'EOFF'
+rather than 'E3OFF' in 'dir3_sf_entry_flds' is a typo, this patch fix
+it, there has no logical change in this commit at all.
+
+Signed-off-by: Xiaole He <hexiaole@kylinos.cn>
+Reviewed-by: Darrick J. Wong <djwong@kernel.org>
+Signed-off-by: Carlos Maiolino <cem@kernel.org>
+---
+ db/dir2sf.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/db/dir2sf.c b/db/dir2sf.c
+index 8165b79..9f1880d 100644
+--- a/db/dir2sf.c
++++ b/db/dir2sf.c
+@@ -246,9 +246,9 @@ const field_t	dir3sf_flds[] = {
+ 
+ #define	E3OFF(f)	bitize(offsetof(xfs_dir2_sf_entry_t, f))
+ const field_t	dir3_sf_entry_flds[] = {
+-	{ "namelen", FLDT_UINT8D, OI(EOFF(namelen)), C1, 0, TYP_NONE },
+-	{ "offset", FLDT_DIR2_SF_OFF, OI(EOFF(offset)), C1, 0, TYP_NONE },
+-	{ "name", FLDT_CHARNS, OI(EOFF(name)), dir2_sf_entry_name_count,
++	{ "namelen", FLDT_UINT8D, OI(E3OFF(namelen)), C1, 0, TYP_NONE },
++	{ "offset", FLDT_DIR2_SF_OFF, OI(E3OFF(offset)), C1, 0, TYP_NONE },
++	{ "name", FLDT_CHARNS, OI(E3OFF(name)), dir2_sf_entry_name_count,
+ 	  FLD_COUNT, TYP_NONE },
+ 	{ "inumber", FLDT_DIR2_INOU, dir3_sf_entry_inumber_offset, C1,
+ 	  FLD_OFFSET, TYP_NONE },
+-- 
+2.27.0
+

xfsprogs.spec

@@ -1,6 +1,6 @@
 Name:           xfsprogs
 Version:        5.6.0
-Release:        6
+Release:        7
 Summary:        Administration and debugging tools for the XFS file system
 License:        GPL+ and LGPLv2+
 URL:            https://xfs.wiki.kernel.org
@@ -20,6 +20,7 @@ Patch10:	0010-xfs-fix-boundary-test-in-xfs_attr_shortform_verify.patch
 Patch11:	0011-xfs-set-xefi_discard-when-creating-a-deferred-agfl-f.patch
 Patch12:        0012-xfs-correct-nlink-printf-specifier-from-hd-to-PRIu32.patch
 Patch13:        0013-libxfs-fix-inode-reservation-space-for-removing-tran.patch
+Patch14:        0014-xfs_db-use-preferable-macro-to-seek-offset-for-local.patch
 
 BuildRequires:  libtool libattr-devel libuuid-devel gcc git gettext
 BuildRequires:  readline-devel libblkid-devel >= 2.30 lvm2-devel libicu-devel >= 62.0
@@ -112,6 +113,9 @@ rm -rf %{buildroot}%{_datadir}/doc/xfsprogs/
 
 
 %changelog
+* Thu Dec  8 2022 Xiaole He <hexiaole@kylinos.cn> - 5.6.0-7
+- add Patch14: use preferable macro to seek offset for local dir3 entry fields
+
 * Thu Aug 18 2022 Xiaole He <hexiaole@kylinos.cn> - 5.6.0-6
 - add Patch13: fix inode reservation space for removing transaction