32 lines
975 B
Diff
32 lines
975 B
Diff
From 5baf73feb4951cc3b3f553a4b18d3b3599cbf87c Mon Sep 17 00:00:00 2001
|
|
From: Michal Domonkos <mdomonko@redhat.com>
|
|
Date: Fri, 25 Jun 2021 11:21:46 +0200
|
|
Subject: [PATCH] Always free the arg list passed to rpmGlob()
|
|
|
|
Even though the actual implementation of rpmGlob() does not allocate the
|
|
passed arg list (av) if the return code (rc) is non-zero or arg count
|
|
(ac) is 0, it's the responsibility of the caller (rpmInstall() here) to
|
|
free that memory, so make sure we do that irrespectively of the above
|
|
conditions.
|
|
|
|
Found by Coverity.
|
|
---
|
|
lib/rpminstall.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/lib/rpminstall.c b/lib/rpminstall.c
|
|
index 724126e94..302ec0ba1 100644
|
|
--- a/lib/rpminstall.c
|
|
+++ b/lib/rpminstall.c
|
|
@@ -461,6 +461,7 @@ int rpmInstall(rpmts ts, struct rpmInstallArguments_s * ia, ARGV_t fileArgv)
|
|
rpmlog(RPMLOG_ERR, _("File not found by glob: %s\n"), *eiu->fnp);
|
|
}
|
|
eiu->numFailed++;
|
|
+ argvFree(av);
|
|
continue;
|
|
}
|
|
|
|
--
|
|
2.27.0
|
|
|