From 3c8b01b67ec907afaaffe71691fa41b878578527 Mon Sep 17 00:00:00 2001 From: Michal Domonkos Date: Mon, 14 Jun 2021 10:21:25 +0200 Subject: [PATCH] Fix resource leak in Fts_children() This function is not used anywhere within our codebase (and neither is it part of the public API) so it's basically a no-op... Still, rather than yanking it completely, let's just silence the Coverity error here. Found by Coverity. --- misc/fts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/fts.c b/misc/fts.c index d3ebb2946..caf27495d 100644 --- a/misc/fts.c +++ b/misc/fts.c @@ -585,8 +585,10 @@ Fts_children(FTS * sp, int instr) if ((fd = __open(".", O_RDONLY, 0)) < 0) return (NULL); sp->fts_child = fts_build(sp, instr); - if (__fchdir(fd)) + if (__fchdir(fd)) { + (void)__close(fd); return (NULL); + } (void)__close(fd); return (sp->fts_child); } -- 2.27.0