9df0eb3b5b
- hw/virtio/virtio-crypto: Protect from DMA re-entrancy bugs(CVE-2024-3446) - hw/char/virtio-serial-bus: Protect from DMA re-entrancy bugs(CVE-2024-3446) - hw/display/virtio-gpu: Protect from DMA re-entrancy bugs(CVE-2024-3446) - hw/virtio: Introduce virtio_bh_new_guarded() helper - hw: replace most qemu_bh_new calls with qemu_bh_new_guarded - checkpatch: add qemu_bh_new/aio_bh_new checks - async: avoid use-after-free on re-entrancy guard - async: Add an optional reentrancy guard to the BH API - util/async: add a human-readable name to BHs for debugging - hw/sd/sdhci: Do not update TRNMOD when Command Inhibit (DAT) is set - Include sysemu/sysemu.h a lot less Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com>
44 lines
1.7 KiB
Diff
44 lines
1.7 KiB
Diff
From 3cd3f9141255fd896cc10abedefab81f1724d53b Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>
|
|
Date: Thu, 4 Apr 2024 20:56:41 +0200
|
|
Subject: [PATCH] hw/virtio/virtio-crypto: Protect from DMA re-entrancy
|
|
bugs(CVE-2024-3446)
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Replace qemu_bh_new_guarded() by virtio_bh_new_guarded()
|
|
so the bus and device use the same guard. Otherwise the
|
|
DMA-reentrancy protection can be bypassed.
|
|
|
|
Fixes: CVE-2024-3446
|
|
Cc: qemu-stable@nongnu.org
|
|
Suggested-by: Alexander Bulekov <alxndr@bu.edu>
|
|
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
Acked-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Message-Id: <20240409105537.18308-5-philmd@linaro.org>
|
|
---
|
|
hw/virtio/virtio-crypto.c | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c
|
|
index 46dab3d6c4..22d0a9a446 100644
|
|
--- a/hw/virtio/virtio-crypto.c
|
|
+++ b/hw/virtio/virtio-crypto.c
|
|
@@ -811,8 +811,8 @@ static void virtio_crypto_device_realize(DeviceState *dev, Error **errp)
|
|
vcrypto->vqs[i].dataq =
|
|
virtio_add_queue(vdev, 1024, virtio_crypto_handle_dataq_bh);
|
|
vcrypto->vqs[i].dataq_bh =
|
|
- qemu_bh_new_guarded(virtio_crypto_dataq_bh, &vcrypto->vqs[i],
|
|
- &dev->mem_reentrancy_guard);
|
|
+ virtio_bh_new_guarded(dev, virtio_crypto_dataq_bh,
|
|
+ &vcrypto->vqs[i]);
|
|
vcrypto->vqs[i].vcrypto = vcrypto;
|
|
}
|
|
|
|
--
|
|
2.27.0
|
|
|