fix CVE-2021-3582/CVE-2021-3607/CVE-2021-3608
hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582) pvrdma: Ensure correct input on ring init (CVE-2021-3607) pvrdma: Fix the ring init error flow (CVE-2021-3608) Signed-off-by: yezengruan <yezengruan@huawei.com>
This commit is contained in:
yezengruan
parent
4abcbecf94
commit
bc7b2dfda0
45
hw-rdma-Fix-possible-mremap-overflow-in-the-pvrdma-d.patch
Normal file
45
hw-rdma-Fix-possible-mremap-overflow-in-the-pvrdma-d.patch
Normal file
@ -0,0 +1,45 @@
|
||||
From be2098de6cafdce46c104d6ff277b7b780631e40 Mon Sep 17 00:00:00 2001
|
||||
From: Marcel Apfelbaum <marcel@redhat.com>
|
||||
Date: Wed, 16 Jun 2021 14:06:00 +0300
|
||||
Subject: [PATCH 1/3] hw/rdma: Fix possible mremap overflow in the pvrdma
|
||||
device (CVE-2021-3582)
|
||||
|
||||
Ensure mremap boundaries not trusting the guest kernel to
|
||||
pass the correct buffer length.
|
||||
|
||||
Fixes: CVE-2021-3582
|
||||
Reported-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
|
||||
Tested-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
|
||||
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
|
||||
Message-Id: <20210616110600.20889-1-marcel.apfelbaum@gmail.com>
|
||||
Reviewed-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
|
||||
Tested-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
|
||||
Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>
|
||||
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
|
||||
cherry-pick from: 284f191b4abad213aed04cb0458e1600fd18d7c4
|
||||
Signed-off-by: yezengruan <yezengruan@huawei.com>
|
||||
---
|
||||
hw/rdma/vmw/pvrdma_cmd.c | 7 +++++++
|
||||
1 file changed, 7 insertions(+)
|
||||
|
||||
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
|
||||
index 8d70c0d23d..dca8f36693 100644
|
||||
--- a/hw/rdma/vmw/pvrdma_cmd.c
|
||||
+++ b/hw/rdma/vmw/pvrdma_cmd.c
|
||||
@@ -39,6 +39,13 @@ static void *pvrdma_map_to_pdir(PCIDevice *pdev, uint64_t pdir_dma,
|
||||
return NULL;
|
||||
}
|
||||
|
||||
+ length = ROUND_UP(length, TARGET_PAGE_SIZE);
|
||||
+ if (nchunks * TARGET_PAGE_SIZE != length) {
|
||||
+ rdma_error_report("Invalid nchunks/length (%u, %lu)", nchunks,
|
||||
+ (unsigned long)length);
|
||||
+ return NULL;
|
||||
+ }
|
||||
+
|
||||
dir = rdma_pci_dma_map(pdev, pdir_dma, TARGET_PAGE_SIZE);
|
||||
if (!dir) {
|
||||
rdma_error_report("Failed to map to page directory");
|
||||
--
|
||||
2.27.0
|
||||
|
||||
41
pvrdma-Ensure-correct-input-on-ring-init-CVE-2021-36.patch
Normal file
41
pvrdma-Ensure-correct-input-on-ring-init-CVE-2021-36.patch
Normal file
@ -0,0 +1,41 @@
|
||||
From 0383586640e2c9712376c795d4d2ea27aadeed78 Mon Sep 17 00:00:00 2001
|
||||
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
|
||||
Date: Wed, 30 Jun 2021 14:46:34 +0300
|
||||
Subject: [PATCH 2/3] pvrdma: Ensure correct input on ring init (CVE-2021-3607)
|
||||
|
||||
Check the guest passed a non zero page count
|
||||
for pvrdma device ring buffers.
|
||||
|
||||
Fixes: CVE-2021-3607
|
||||
Reported-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
|
||||
Reviewed-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
|
||||
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
|
||||
Message-Id: <20210630114634.2168872-1-marcel@redhat.com>
|
||||
Reviewed-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
|
||||
Tested-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
|
||||
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
|
||||
cherry-pick from: 32e5703cfea07c91e6e84bcb0313f633bb146534
|
||||
Signed-off-by: yezengruan <yezengruan@huawei.com>
|
||||
---
|
||||
hw/rdma/vmw/pvrdma_main.c | 5 +++++
|
||||
1 file changed, 5 insertions(+)
|
||||
|
||||
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
|
||||
index adcf79cd63..1d9f84e89a 100644
|
||||
--- a/hw/rdma/vmw/pvrdma_main.c
|
||||
+++ b/hw/rdma/vmw/pvrdma_main.c
|
||||
@@ -93,6 +93,11 @@ static int init_dev_ring(PvrdmaRing *ring, struct pvrdma_ring **ring_state,
|
||||
uint64_t *dir, *tbl;
|
||||
int rc = 0;
|
||||
|
||||
+ if (!num_pages) {
|
||||
+ rdma_error_report("Ring pages count must be strictly positive");
|
||||
+ return -EINVAL;
|
||||
+ }
|
||||
+
|
||||
dir = rdma_pci_dma_map(pci_dev, dir_addr, TARGET_PAGE_SIZE);
|
||||
if (!dir) {
|
||||
rdma_error_report("Failed to map to page directory (ring %s)", name);
|
||||
--
|
||||
2.27.0
|
||||
|
||||
41
pvrdma-Fix-the-ring-init-error-flow-CVE-2021-3608.patch
Normal file
41
pvrdma-Fix-the-ring-init-error-flow-CVE-2021-3608.patch
Normal file
@ -0,0 +1,41 @@
|
||||
From ad63c75ceea0b9d6fe1dbb008cad41527a29f923 Mon Sep 17 00:00:00 2001
|
||||
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
|
||||
Date: Wed, 30 Jun 2021 14:52:46 +0300
|
||||
Subject: [PATCH 3/3] pvrdma: Fix the ring init error flow (CVE-2021-3608)
|
||||
MIME-Version: 1.0
|
||||
Content-Type: text/plain; charset=UTF-8
|
||||
Content-Transfer-Encoding: 8bit
|
||||
|
||||
Do not unmap uninitialized dma addresses.
|
||||
|
||||
Fixes: CVE-2021-3608
|
||||
Reviewed-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
|
||||
Tested-by: VictorV (Kunlun Lab) <vv474172261@gmail.com>
|
||||
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
|
||||
Message-Id: <20210630115246.2178219-1-marcel@redhat.com>
|
||||
Tested-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
|
||||
Reviewed-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
|
||||
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
||||
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
|
||||
cherry-pick from: 66ae37d8cc313f89272e711174a846a229bcdbd3
|
||||
Signed-off-by: yezengruan <yezengruan@huawei.com>
|
||||
---
|
||||
hw/rdma/vmw/pvrdma_dev_ring.c | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c b/hw/rdma/vmw/pvrdma_dev_ring.c
|
||||
index d7bc7f5ccc..2a620ad5bc 100644
|
||||
--- a/hw/rdma/vmw/pvrdma_dev_ring.c
|
||||
+++ b/hw/rdma/vmw/pvrdma_dev_ring.c
|
||||
@@ -41,7 +41,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name, PCIDevice *dev,
|
||||
atomic_set(&ring->ring_state->cons_head, 0);
|
||||
*/
|
||||
ring->npages = npages;
|
||||
- ring->pages = g_malloc(npages * sizeof(void *));
|
||||
+ ring->pages = g_malloc0(npages * sizeof(void *));
|
||||
|
||||
for (i = 0; i < npages; i++) {
|
||||
if (!tbl[i]) {
|
||||
--
|
||||
2.27.0
|
||||
|
||||
10
qemu.spec
10
qemu.spec
@ -1,6 +1,6 @@
|
||||
Name: qemu
|
||||
Version: 4.1.0
|
||||
Release: 64
|
||||
Release: 65
|
||||
Epoch: 2
|
||||
Summary: QEMU is a generic and open source machine emulator and virtualizer
|
||||
License: GPLv2 and BSD and MIT and CC-BY-SA-4.0
|
||||
@ -345,6 +345,9 @@ Patch0332: fix-cve-2020-35505.patch
|
||||
Patch0333: virtio-balloon-apply-upstream-patch.patch
|
||||
Patch0334: add-Phytium-s-CPU-models-FT-2000-and-Tengyun-S2500.patch
|
||||
Patch0335: hw-scsi-scsi-disk-MODE_PAGE_ALLS-not-allowed-in-MODE.patch
|
||||
Patch0336: hw-rdma-Fix-possible-mremap-overflow-in-the-pvrdma-d.patch
|
||||
Patch0337: pvrdma-Ensure-correct-input-on-ring-init-CVE-2021-36.patch
|
||||
Patch0338: pvrdma-Fix-the-ring-init-error-flow-CVE-2021-3608.patch
|
||||
|
||||
BuildRequires: flex
|
||||
BuildRequires: bison
|
||||
@ -741,6 +744,11 @@ getent passwd qemu >/dev/null || \
|
||||
%endif
|
||||
|
||||
%changelog
|
||||
* Wed Apr 06 2022 yezengruan <yezengruan@huawei.com>
|
||||
- hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582)
|
||||
- pvrdma: Ensure correct input on ring init (CVE-2021-3607)
|
||||
- pvrdma: Fix the ring init error flow (CVE-2021-3608)
|
||||
|
||||
* Mon Mar 28 2022 Jinhao Gao <gaojinhao@huawei.com>
|
||||
- hw/scsi/scsi-disk: MODE_PAGE_ALLS not allowed in MODE SELECT commands(fix CVE-2021-3930)
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user