09e7eb51d9
When "multipath -f" is run on a device that doesn't exist or isn't a multipath device, the command will not remove any device, but it will still return success. Multiple functions rely on _dm_flush_map() returning success when called with name that doesn't match any multipath device. So before calling _dm_flush_map(), call dm_is_mpath(), to check if the device exists and is a multipath device, and return failure if it's not.
39 lines
1.3 KiB
Diff
39 lines
1.3 KiB
Diff
From 774b5ad984a9c4f1d8d869d804ad1dc35dab7d8b Mon Sep 17 00:00:00 2001
|
|
From: Benjamin Marzinski <bmarzins@redhat.com>
|
|
Date: Wed, 30 Mar 2022 15:14:56 -0500
|
|
Subject: [PATCH] multipath: return failure on an invalid remove command
|
|
|
|
When "multipath -f" is run on a device that doesn't exist or isn't a
|
|
multipath device, the command will not remove any device, but it will
|
|
still return success. Multiple functions rely on _dm_flush_map()
|
|
returning success when called with name that doesn't match any
|
|
multipath device. So before calling _dm_flush_map(), call dm_is_mpath(),
|
|
to check if the device exists and is a multipath device, and return
|
|
failure if it's not.
|
|
|
|
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
|
Reviewed-by: Martin Wilck <mwilck@suse.com
|
|
---
|
|
multipath/main.c | 5 +++++
|
|
1 file changed, 5 insertions(+)
|
|
|
|
diff --git a/multipath/main.c b/multipath/main.c
|
|
index f52430f..008de0b 100644
|
|
--- a/multipath/main.c
|
|
+++ b/multipath/main.c
|
|
@@ -1088,6 +1088,11 @@ main (int argc, char *argv[])
|
|
retries = conf->remove_retries;
|
|
if (conf->remove == FLUSH_ONE) {
|
|
if (dev_type == DEV_DEVMAP) {
|
|
+ if (dm_is_mpath(dev) != 1) {
|
|
+ condlog(0, "%s is not a multipath device", dev);
|
|
+ r = RTVL_FAIL;
|
|
+ goto out;
|
|
+ }
|
|
r = dm_suspend_and_flush_map(dev, retries) ?
|
|
RTVL_FAIL : RTVL_OK;
|
|
} else
|
|
--
|
|
2.27.0
|
|
|