Fix leaking file descriptor to child processes

This commit is contained in:
Kou Wenqi 2024-07-18 17:28:33 +08:00
parent 8829b60653
commit cf2c17486d
2 changed files with 33 additions and 1 deletions

View File

@ -0,0 +1,28 @@
From c8e627016edd1440c8faf6f9b8f4092a83e01164 Mon Sep 17 00:00:00 2001
From: David Edmundson <kde@davidedmundson.co.uk>
Date: Wed, 1 Nov 2023 14:32:43 +0000
Subject: [PATCH] inotify: Avoid leaking file descriptor to child processes
inotify_init creates a file descriptor which by default is not makes
with CLOEXEC. If the application using libusbmuxd spawns applications
this then leaks through.
---
src/libusbmuxd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libusbmuxd.c b/src/libusbmuxd.c
index af8636b..e922106 100644
--- a/src/libusbmuxd.c
+++ b/src/libusbmuxd.c
@@ -544,7 +544,7 @@ static int usbmuxd_listen_inotify()
return sfd;
sfd = -1;
- inot_fd = inotify_init ();
+ inot_fd = inotify_init1(IN_CLOEXEC);
if (inot_fd < 0) {
DEBUG(1, "%s: Failed to setup inotify\n", __func__);
return -2;
--
2.27.0

View File

@ -1,11 +1,12 @@
Name: libusbmuxd
Version: 1.0.10
Release: 12
Release: 13
Summary: software protocol library and tools to communicate with iOS devices natively
License: LGPLv2+ and GPLv2+
URL: http://www.libimobiledevice.org/
Source0: http://www.libimobiledevice.org/downloads/%{name}-%{version}.tar.bz2
Patch0: 6000-CVE-2016-5104.patch
Patch1: 6001-inotify-Avoid-leaking-file-descriptor-to-child-proce.patch
BuildRequires: gcc git libplist-devel >= 1.11
Provides: %{name}-utils
@ -57,6 +58,9 @@ make check
%{_libdir}/pkgconfig/libusbmuxd.pc
%changelog
* Thu Jul 18 2024 kouwenqi <kouwenqi@kylinos.cn> - 1.0.10-13
- Fix leaking file descriptor to child processes
* Fri Aug 30 2019 louhongxiang <louhongxiang@huawei.com> - 1.0.10-12
- Type:enhancemnet
- ID:NA