packages/ksh
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

!48 solve the problem of dereference null return value when moving a job to the head of the linked list

Browse Source 
From: @wangyuhang27 
Reviewed-by: @licunlong 
Signed-off-by: @licunlong
This commit is contained in:
openeuler-ci-bot 2024-05-07 12:27:31 +00:00 committed by Gitee
commit 17b53dc188
No known key found for this signature in database
GPG Key ID: 173E9B9CA92EEF8F
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ksh.spec
View File

@ -1,6 +1,6 @@
Name: ksh
Version: 2020.0.0
Release: 7
Release: 8
Summary: The Original ATT Korn Shell
License: EPL-1.0
URL: http://www.kornshell.com/
@ -17,6 +17,8 @@ Patch6002: backport-functions-with-not-loaded-autoloaded-functions.patch
Patch6003: backport-Fix-handling-of-skipped-directories.patch
Patch6004: backport-Fix-interactive-restricted-shell-behavior.patch
Patch9000: solve-the-problem-of-dereference-null-return-value-w.patch
Provides: /bin/ksh /usr/bin/ksh
BuildRequires: meson gcc glibc-devel ed
Conflicts: pdksh
@ -89,6 +91,9 @@ done
%config(noreplace) %{_sysconfdir}/binfmt.d/kshcomp.conf
%changelog
* Tue May 7 2024 wangyuhang <wangyuhang27@huawei.com> - 1:2020.0.0-8
- solve the problem of dereference null return value when moving a job to the head of the linked list
* Thu Dec 7 2023 wangyuhang <wangyuhang27@huawei.com> - 1:2020.0.0-7
- Type:bugfix
- ID:NA

32
solve-the-problem-of-dereference-null-return-value-w.patch Normal file
View File

@ -0,0 +1,32 @@
From ed22939428be3bd676e4261cf96e144c15d4e686 Mon Sep 17 00:00:00 2001
From: wangyuhang <wangyuhang27>
Date: Tue, 2 Apr 2024 15:44:35 +0800
Subject: [PATCH] solve the problem of dereference null return value when
moving a job to the head of the linked list
---
src/cmd/ksh93/sh/jobs.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/cmd/ksh93/sh/jobs.c b/src/cmd/ksh93/sh/jobs.c
index 5ad42c0..a46de01 100644
--- a/src/cmd/ksh93/sh/jobs.c
+++ b/src/cmd/ksh93/sh/jobs.c
@@ -1105,10 +1105,11 @@ int job_post(Shell_t *shp, pid_t pid, pid_t join) {
val = job.curjobid;
}
// If job to join is not first move it to front.
- if (val) {
+ if (val && job.pwlist) {
pw = job_byjid(val);
- assert(pw);
- if (pw != job.pwlist) {
+ if (!pw)
+ errormsg(SH_DICT, ERROR_warn(0), "the job cannot be found in the linked list");
+ if (pw && (pw != job.pwlist)) {
job_unlink(pw);
pw->p_nxtjob = job.pwlist;
job.pwlist = pw;
--
2.33.0