81 lines
2.8 KiB
Diff
81 lines
2.8 KiB
Diff
From 2fcba35dbd7a5173a3e38190b5fb8e659d6ed091 Mon Sep 17 00:00:00 2001
|
|
From: Ian Rogers <irogers@google.com>
|
|
Date: Wed, 13 May 2020 14:29:33 -0700
|
|
Subject: [PATCH 076/201] perf test: Provide a subtest callback to ask for the
|
|
reason for skipping a subtest
|
|
|
|
mainline inclusion
|
|
from mainline-v5.8-rc1
|
|
commit 3b536651eeb7667808de7651f0858c932a3c4138
|
|
category: feature
|
|
bugzilla: https://gitee.com/openeuler/kernel/issues/I8C0CX
|
|
|
|
Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3b536651eeb7667808de7651f0858c932a3c4138
|
|
|
|
----------------------------------------------------------------------
|
|
|
|
Now subtests can inform why a test was skipped. The upcoming patch
|
|
improvint PMU event metric testing will use it.
|
|
|
|
Signed-off-by: Ian Rogers <irogers@google.com>
|
|
Cc: Adrian Hunter <adrian.hunter@intel.com>
|
|
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
|
|
Cc: Andi Kleen <ak@linux.intel.com>
|
|
Cc: Jin Yao <yao.jin@linux.intel.com>
|
|
Cc: Jiri Olsa <jolsa@redhat.com>
|
|
Cc: John Garry <john.garry@huawei.com>
|
|
Cc: Kajol Jain <kjain@linux.ibm.com>
|
|
Cc: Kan Liang <kan.liang@linux.intel.com>
|
|
Cc: Leo Yan <leo.yan@linaro.org>
|
|
Cc: Mark Rutland <mark.rutland@arm.com>
|
|
Cc: Namhyung Kim <namhyung@kernel.org>
|
|
Cc: Paul Clarke <pc@us.ibm.com>
|
|
Cc: Peter Zijlstra <peterz@infradead.org>
|
|
Cc: Stephane Eranian <eranian@google.com>
|
|
Link: http://lore.kernel.org/lkml/20200513212933.41273-1-irogers@google.com
|
|
[ split from a larger patch ]
|
|
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
|
|
Signed-off-by: hongrongxuan <hongrongxuan@huawei.com>
|
|
---
|
|
tools/perf/tests/builtin-test.c | 11 +++++++++--
|
|
tools/perf/tests/tests.h | 1 +
|
|
2 files changed, 10 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
|
|
index 1925f170478c..b4b1e34aaef4 100644
|
|
--- a/tools/perf/tests/builtin-test.c
|
|
+++ b/tools/perf/tests/builtin-test.c
|
|
@@ -406,8 +406,15 @@ static int test_and_print(struct test *t, bool force_skip, int subtest)
|
|
case TEST_OK:
|
|
pr_info(" Ok\n");
|
|
break;
|
|
- case TEST_SKIP:
|
|
- color_fprintf(stderr, PERF_COLOR_YELLOW, " Skip\n");
|
|
+ case TEST_SKIP: {
|
|
+ const char *skip_reason = NULL;
|
|
+ if (t->subtest.skip_reason)
|
|
+ skip_reason = t->subtest.skip_reason(subtest);
|
|
+ if (skip_reason)
|
|
+ color_fprintf(stderr, PERF_COLOR_YELLOW, " Skip (%s)\n", skip_reason);
|
|
+ else
|
|
+ color_fprintf(stderr, PERF_COLOR_YELLOW, " Skip\n");
|
|
+ }
|
|
break;
|
|
case TEST_FAIL:
|
|
default:
|
|
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
|
|
index 7d2997c9fca7..897ca3e7812c 100644
|
|
--- a/tools/perf/tests/tests.h
|
|
+++ b/tools/perf/tests/tests.h
|
|
@@ -34,6 +34,7 @@ struct test {
|
|
bool skip_if_fail;
|
|
int (*get_nr)(void);
|
|
const char *(*get_desc)(int subtest);
|
|
+ const char *(*skip_reason)(int subtest);
|
|
} subtest;
|
|
bool (*is_supported)(void);
|
|
void *priv;
|
|
--
|
|
2.27.0
|
|
|