186 lines
6.6 KiB
Diff
186 lines
6.6 KiB
Diff
From 90b0e05e773e5dbdf603a7efa64e90e5e9aa42d0 Mon Sep 17 00:00:00 2001
|
|
From: Guangbin Huang <huangguangbin2@huawei.com>
|
|
Date: Sun, 27 Sep 2020 15:12:41 +0800
|
|
Subject: [PATCH 034/283] net: hns3: add support to query device capability
|
|
|
|
mainline inclusion
|
|
from mainline-v5.10-rc1
|
|
commit ca850f2b0ecbb24f03a706d4d11203565030570a
|
|
category: feature
|
|
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8EMQV
|
|
|
|
Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca850f2b0ecbb24f03a706d4d11203565030570a
|
|
|
|
--------------------------------
|
|
|
|
In order to improve code maintainability and compatibility,
|
|
add support to query the device capability by expanding the
|
|
existing version query command. The device capability refers
|
|
to the features supported by the device.
|
|
|
|
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
|
|
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
Signed-off-by: Xiaodong Li <lixiaodong67@huawei.com>
|
|
|
|
Conflicts:
|
|
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
|
|
---
|
|
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 10 ----------
|
|
.../ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 15 ++++++++++++---
|
|
.../ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 4 +++-
|
|
.../ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 15 ++++++++++++---
|
|
.../ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h | 4 +++-
|
|
5 files changed, 30 insertions(+), 18 deletions(-)
|
|
|
|
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
|
|
index 3784001b09a7..f55dd10ab554 100644
|
|
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
|
|
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
|
|
@@ -2162,15 +2162,6 @@ static void hns3_disable_sriov(struct pci_dev *pdev)
|
|
pci_disable_sriov(pdev);
|
|
}
|
|
|
|
-static void hns3_get_dev_capability(struct pci_dev *pdev,
|
|
- struct hnae3_ae_dev *ae_dev)
|
|
-{
|
|
- if (ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V2) {
|
|
- hnae3_set_bit(ae_dev->flag, HNAE3_DEV_SUPPORT_FD_B, 1);
|
|
- hnae3_set_bit(ae_dev->flag, HNAE3_DEV_SUPPORT_GRO_B, 1);
|
|
- }
|
|
-}
|
|
-
|
|
/* hns3_probe - Device initialization routine
|
|
* @pdev: PCI device information struct
|
|
* @ent: entry in hns3_pci_tbl
|
|
@@ -2192,7 +2183,6 @@ static int hns3_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
|
|
|
|
ae_dev->pdev = pdev;
|
|
ae_dev->flag = ent->driver_data;
|
|
- hns3_get_dev_capability(pdev, ae_dev);
|
|
pci_set_drvdata(pdev, ae_dev);
|
|
|
|
ret = hnae3_register_ae_dev(ae_dev);
|
|
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
|
|
index 114970c8e21a..d9c4e82b0d21 100644
|
|
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
|
|
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
|
|
@@ -346,7 +346,8 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
|
|
return retval;
|
|
}
|
|
|
|
-static enum hclge_cmd_status hclge_cmd_query_version(struct hclge_dev *hdev)
|
|
+static enum hclge_cmd_status
|
|
+hclge_cmd_query_version_and_capability(struct hclge_dev *hdev)
|
|
{
|
|
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(hdev->pdev);
|
|
struct hclge_query_version_cmd *resp;
|
|
@@ -366,6 +367,12 @@ static enum hclge_cmd_status hclge_cmd_query_version(struct hclge_dev *hdev)
|
|
HNAE3_PCI_REVISION_BIT_SIZE;
|
|
ae_dev->dev_version |= hdev->pdev->revision;
|
|
|
|
+ if (!resp->caps[0] &&
|
|
+ ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V2) {
|
|
+ hnae3_set_bit(ae_dev->flag, HNAE3_DEV_SUPPORT_FD_B, 1);
|
|
+ hnae3_set_bit(ae_dev->flag, HNAE3_DEV_SUPPORT_GRO_B, 1);
|
|
+ }
|
|
+
|
|
return ret;
|
|
}
|
|
|
|
@@ -460,10 +467,12 @@ int hclge_cmd_init(struct hclge_dev *hdev)
|
|
goto err_cmd_init;
|
|
}
|
|
|
|
- ret = hclge_cmd_query_version(hdev);
|
|
+ /* get version and device capabilities */
|
|
+ ret = hclge_cmd_query_version_and_capability(hdev);
|
|
if (ret) {
|
|
dev_err(&hdev->pdev->dev,
|
|
- "failed to query version ret=%d\n", ret);
|
|
+ "failed to query version and capabilities, ret = %d\n",
|
|
+ ret);
|
|
goto err_cmd_init;
|
|
}
|
|
|
|
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h
|
|
index c43bae3ecbfe..d565633abab3 100644
|
|
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h
|
|
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h
|
|
@@ -369,10 +369,12 @@ struct hclge_rx_priv_buff_cmd {
|
|
u8 rsv[6];
|
|
};
|
|
|
|
+#define HCLGE_QUERY_CAP_LENGTH 3
|
|
struct hclge_query_version_cmd {
|
|
__le32 firmware;
|
|
__le32 hardware;
|
|
- __le32 rsv[4];
|
|
+ __le32 rsv;
|
|
+ __le32 caps[HCLGE_QUERY_CAP_LENGTH]; /* capabilities of device */
|
|
};
|
|
|
|
#define HCLGE_RX_PRIV_EN_B 15
|
|
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
|
|
index 4585a22f0003..20db8fb98604 100644
|
|
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
|
|
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
|
|
@@ -329,7 +329,7 @@ int hclgevf_cmd_send(struct hclgevf_hw *hw, struct hclgevf_desc *desc, int num)
|
|
return status;
|
|
}
|
|
|
|
-static int hclgevf_cmd_query_version(struct hclgevf_dev *hdev)
|
|
+static int hclgevf_cmd_query_version_and_capability(struct hclgevf_dev *hdev)
|
|
{
|
|
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(hdev->pdev);
|
|
struct hclgevf_query_version_cmd *resp;
|
|
@@ -349,6 +349,12 @@ static int hclgevf_cmd_query_version(struct hclgevf_dev *hdev)
|
|
HNAE3_PCI_REVISION_BIT_SIZE;
|
|
ae_dev->dev_version |= hdev->pdev->revision;
|
|
|
|
+ if (!resp->caps[0] &&
|
|
+ ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V2) {
|
|
+ hnae3_set_bit(ae_dev->flag, HNAE3_DEV_SUPPORT_FD_B, 1);
|
|
+ hnae3_set_bit(ae_dev->flag, HNAE3_DEV_SUPPORT_GRO_B, 1);
|
|
+ }
|
|
+
|
|
return status;
|
|
}
|
|
|
|
@@ -421,9 +427,12 @@ int hclgevf_cmd_init(struct hclgevf_dev *hdev)
|
|
goto err_cmd_init;
|
|
}
|
|
|
|
- ret = hclgevf_cmd_query_version(hdev);
|
|
+ /* get version and device capabilities */
|
|
+ ret = hclgevf_cmd_query_version_and_capability(hdev);
|
|
if (ret) {
|
|
- dev_err(&hdev->pdev->dev, "failed(%d) to query version\n", ret);
|
|
+ dev_err(&hdev->pdev->dev,
|
|
+ "failed to query version and capabilities, ret = %d\n",
|
|
+ ret);
|
|
goto err_cmd_init;
|
|
}
|
|
|
|
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h
|
|
index a797f770a9fa..b59ca89f52cc 100644
|
|
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h
|
|
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h
|
|
@@ -142,10 +142,12 @@ struct hclgevf_ctrl_vector_chain {
|
|
u8 resv;
|
|
};
|
|
|
|
+#define HCLGEVF_QUERY_CAP_LENGTH 3
|
|
struct hclgevf_query_version_cmd {
|
|
__le32 firmware;
|
|
__le32 hardware;
|
|
- __le32 rsv[4];
|
|
+ __le32 rsv;
|
|
+ __le32 caps[HCLGEVF_QUERY_CAP_LENGTH]; /* capabilities of device */
|
|
};
|
|
|
|
#define HCLGEVF_MSIX_OFT_ROCEE_S 0
|
|
--
|
|
2.34.1
|
|
|