172 lines
6.0 KiB
Diff
172 lines
6.0 KiB
Diff
From 6bc7b166d7a3d17413c0d948553f18b66dbfe42d Mon Sep 17 00:00:00 2001
|
|
From: Leo Yan <leo.yan@linaro.org>
|
|
Date: Fri, 31 Dec 2021 13:32:11 +0800
|
|
Subject: [PATCH 14/21] perf arm-spe: Refactor event type handling
|
|
|
|
mainline inclusion
|
|
from mainline-v5.11-rc1
|
|
commit 889d1a675fcfe734f83c459de023a6f0a91a7a0e
|
|
category: feature
|
|
bugzilla: https://gitee.com/openeuler/kernel/issues/I4NGPV
|
|
CVE: NA
|
|
|
|
-------------------------------------------------
|
|
|
|
Move the enums of event types to arm-spe-pkt-decoder.h, thus function
|
|
arm_spe_pkt_desc_event() can use them for bitmasks.
|
|
|
|
Suggested-by: Andre Przywara <andre.przywara@arm.com>
|
|
Signed-off-by: Leo Yan <leo.yan@linaro.org>
|
|
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
|
|
Acked-by: Will Deacon <will@kernel.org>
|
|
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
|
|
Cc: Al Grant <Al.Grant@arm.com>
|
|
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
|
|
Cc: Dave Martin <Dave.Martin@arm.com>
|
|
Cc: Ingo Molnar <mingo@redhat.com>
|
|
Cc: James Clark <james.clark@arm.com>
|
|
Cc: Jiri Olsa <jolsa@redhat.com>
|
|
Cc: John Garry <john.garry@huawei.com>
|
|
Cc: Mark Rutland <mark.rutland@arm.com>
|
|
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
|
|
Cc: Namhyung Kim <namhyung@kernel.org>
|
|
Cc: Peter Zijlstra <peterz@infradead.org>
|
|
Cc: Wei Li <liwei391@huawei.com>
|
|
Link: https://lore.kernel.org/r/20201119152441.6972-11-leo.yan@linaro.org
|
|
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
|
|
Signed-off-by: Wei Li <liwei391@huawei.com>
|
|
Reviewed-by: Yang Jihong <yangjihong1@huawei.com>
|
|
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
|
|
Signed-off-by: hongrongxuan <hongrongxuan@huawei.com>
|
|
|
|
Conflicts:
|
|
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
|
|
---
|
|
.../util/arm-spe-decoder/arm-spe-decoder.c | 4 ++--
|
|
.../util/arm-spe-decoder/arm-spe-decoder.h | 14 ------------
|
|
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 22 +++++++++----------
|
|
.../arm-spe-decoder/arm-spe-pkt-decoder.h | 18 +++++++++++++++
|
|
4 files changed, 31 insertions(+), 27 deletions(-)
|
|
|
|
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
|
|
index 3993c1524c73..2ca980fff04a 100644
|
|
--- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
|
|
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
|
|
@@ -200,13 +200,13 @@ static int arm_spe_walk_trace(struct arm_spe_decoder *decoder)
|
|
}
|
|
break;
|
|
case ARM_SPE_EVENTS:
|
|
- if (payload & BIT(EV_TLB_REFILL)) {
|
|
+ if (payload & BIT(EV_TLB_WALK)) {
|
|
decoder->state.type |= ARM_SPE_TLB_MISS;
|
|
decoder->state.is_tlb_miss = true;
|
|
}
|
|
if (payload & BIT(EV_MISPRED))
|
|
decoder->state.type |= ARM_SPE_BRANCH_MISS;
|
|
- if (idx > 1 && (payload & BIT(EV_LLC_REFILL))) {
|
|
+ if (idx > 1 && (payload & BIT(EV_LLC_MISS))) {
|
|
decoder->state.type |= ARM_SPE_LLC_MISS;
|
|
decoder->state.is_llc_miss = true;
|
|
}
|
|
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
|
|
index 36d593eda778..17db7d1c14a9 100644
|
|
--- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
|
|
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
|
|
@@ -6,20 +6,6 @@
|
|
#include <stddef.h>
|
|
#include <stdbool.h>
|
|
|
|
-enum arm_spe_events {
|
|
- EV_EXCEPTION_GEN,
|
|
- EV_RETIRED,
|
|
- EV_L1D_ACCESS,
|
|
- EV_L1D_REFILL,
|
|
- EV_TLB_ACCESS,
|
|
- EV_TLB_REFILL,
|
|
- EV_NOT_TAKEN,
|
|
- EV_MISPRED,
|
|
- EV_LLC_ACCESS,
|
|
- EV_LLC_REFILL,
|
|
- EV_REMOTE_ACCESS,
|
|
-};
|
|
-
|
|
enum arm_spe_sample_type {
|
|
ARM_SPE_LLC_MISS = 1 << 0,
|
|
ARM_SPE_TLB_MISS = 1 << 1,
|
|
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
|
|
index da6b9f76739c..3f30b2937715 100644
|
|
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
|
|
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
|
|
@@ -295,28 +295,28 @@ static int arm_spe_pkt_desc_event(const struct arm_spe_pkt *packet,
|
|
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, "EV");
|
|
|
|
- if (payload & 0x1)
|
|
+ if (payload & BIT(EV_EXCEPTION_GEN))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " EXCEPTION-GEN");
|
|
- if (payload & 0x2)
|
|
+ if (payload & BIT(EV_RETIRED))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " RETIRED");
|
|
- if (payload & 0x4)
|
|
+ if (payload & BIT(EV_L1D_ACCESS))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " L1D-ACCESS");
|
|
- if (payload & 0x8)
|
|
+ if (payload & BIT(EV_L1D_REFILL))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " L1D-REFILL");
|
|
- if (payload & 0x10)
|
|
+ if (payload & BIT(EV_TLB_ACCESS))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " TLB-ACCESS");
|
|
- if (payload & 0x20)
|
|
+ if (payload & BIT(EV_TLB_WALK))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " TLB-REFILL");
|
|
- if (payload & 0x40)
|
|
+ if (payload & BIT(EV_NOT_TAKEN))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " NOT-TAKEN");
|
|
- if (payload & 0x80)
|
|
+ if (payload & BIT(EV_MISPRED))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " MISPRED");
|
|
if (packet->index > 1) {
|
|
- if (payload & 0x100)
|
|
+ if (payload & BIT(EV_LLC_ACCESS))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " LLC-ACCESS");
|
|
- if (payload & 0x200)
|
|
+ if (payload & BIT(EV_LLC_MISS))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " LLC-REFILL");
|
|
- if (payload & 0x400)
|
|
+ if (payload & BIT(EV_REMOTE_ACCESS))
|
|
arm_spe_pkt_out_string(&err, &buf, &buf_len, " REMOTE-ACCESS");
|
|
}
|
|
|
|
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
|
|
index 7d8e34e35f05..42ed4e61ede2 100644
|
|
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
|
|
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
|
|
@@ -87,6 +87,24 @@ struct arm_spe_pkt {
|
|
#define SPE_CNT_PKT_HDR_INDEX_ISSUE_LAT 0x1
|
|
#define SPE_CNT_PKT_HDR_INDEX_TRANS_LAT 0x2
|
|
|
|
+/* Event packet payload */
|
|
+enum arm_spe_events {
|
|
+ EV_EXCEPTION_GEN = 0,
|
|
+ EV_RETIRED = 1,
|
|
+ EV_L1D_ACCESS = 2,
|
|
+ EV_L1D_REFILL = 3,
|
|
+ EV_TLB_ACCESS = 4,
|
|
+ EV_TLB_WALK = 5,
|
|
+ EV_NOT_TAKEN = 6,
|
|
+ EV_MISPRED = 7,
|
|
+ EV_LLC_ACCESS = 8,
|
|
+ EV_LLC_MISS = 9,
|
|
+ EV_REMOTE_ACCESS = 10,
|
|
+ EV_ALIGNMENT = 11,
|
|
+ EV_PARTIAL_PREDICATE = 17,
|
|
+ EV_EMPTY_PREDICATE = 18,
|
|
+};
|
|
+
|
|
const char *arm_spe_pkt_name(enum arm_spe_pkt_type);
|
|
|
|
int arm_spe_get_packet(const unsigned char *buf, size_t len,
|
|
--
|
|
2.27.0
|
|
|