cronie/backport-anacron-Use-xclose-instead-of-fclose.patch
hongjinghao 18dedac5e6 anacron Use xclose instead of fclose
(cherry picked from commit aa10d6863df9fff8c53a44ac91030fde59f5e9d0)
2023-12-04 19:57:16 +08:00

47 lines
1.3 KiB
Diff

From 880489e42a652b84c7de348f0167dfd26abca326 Mon Sep 17 00:00:00 2001
From: Tomas Mraz <tmraz@fedoraproject.org>
Date: Fri, 13 Oct 2023 10:40:05 +0200
Subject: [PATCH] anacron: Use xclose() instead of fclose()
When replacing standard descriptors we use
xclose() elsewhere and it is less error-prone.
Fixes #156
---
anacron/main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/anacron/main.c b/anacron/main.c
index d092970..3ede1d2 100644
--- a/anacron/main.c
+++ b/anacron/main.c
@@ -207,11 +207,11 @@ go_background(void)
/* stdin is already closed */
- if (fclose(stdout)) die_e("Can't close stdout");
- xopen(1, "/dev/null", O_WRONLY);
+ xclose(STDOUT_FILENO);
+ xopen(STDOUT_FILENO, "/dev/null", O_WRONLY);
- if (fclose(stderr)) die_e("Can't close stderr");
- xopen(2, "/dev/null", O_WRONLY);
+ xclose(STDERR_FILENO);
+ xopen(STDERR_FILENO, "/dev/null", O_WRONLY);
pid = xfork();
if (pid != 0)
@@ -472,7 +472,7 @@ main(int argc, char *argv[])
if (sigprocmask(0, NULL, &old_sigmask)) die_e("sigset error");
- if (fclose(stdin)) die_e("Can't close stdin");
+ xclose(STDIN_FILENO);
xopen(STDIN_FILENO, "/dev/null", O_RDONLY);
if (!no_daemon && !testing_only)
--
2.33.0